rmf_obstacle_ros2 #210
Merged
rmf_obstacle_ros2 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
…gins Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 17.78% 17.72% -0.07%
==========================================
Files 422 422
Lines 38906 39178 +272
Branches 18686 18900 +214
==========================================
+ Hits 6919 6943 +24
- Misses 24541 24654 +113
- Partials 7446 7581 +135
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
ahcorde
requested changes
Nov 14, 2022
rmf_obstacle_ros2/include/rmf_obstacle_ros2/obstacles/Convert.hpp
Outdated
Show resolved
Hide resolved
rmf_obstacle_ros2/src/lane_blocker/test/test_IntersectionChecker.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
force-pushed
the
feature/rmf_obstacle
branch
from
bf5bc13
to
ddf188e
Compare
|
There is an issue with this commit the NLohmann's JSON version is not the required. At least in /__w/rmf_ros2/rmf_ros2/ros_ws/build/nlohmann_json_schema_validator_vendor/nlohmann_json_schema_validator-1063c9adbafc25f5a14bae15c3babdb039de86c6-prefix/src/nlohmann_json_schema_validator-1063c9adbafc25f5a14bae15c3babdb039de86c6/src/nlohmann/json-schema.hpp:28:4: error: "Please use this library with NLohmann's JSON version 3.8.0 or higher"
# error "Please use this library with NLohmann's JSON version 3.8.0 or higher"
^ |
* add FleetUpdateHandle speed limit API to python bindings Signed-off-by: Pranay Shirodkar <[email protected]> * add continuous checker option for dynamic obstacles Signed-off-by: Pranay Shirodkar <[email protected]> * refactor Lane Close and Open msg building Signed-off-by: Pranay Shirodkar <[email protected]> * add speed limits Signed-off-by: Pranay Shirodkar <[email protected]> * Fix style Signed-off-by: Yadunund <[email protected]> * Fix const correctness and do not pass unordered_map by ref to publisher Signed-off-by: Yadunund <[email protected]> Signed-off-by: Pranay Shirodkar <[email protected]> Signed-off-by: Yadunund <[email protected]> Co-authored-by: Yadunund <[email protected]> Co-authored-by: Yadunund <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
@Yadunund related to this TODO 9bc9770 Is there any way to check if a lane is closed ? I can't find something usefull in the |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
…between these functions Signed-off-by: Alejandro Hernández Cordero <[email protected]>
…alization Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
requested changes
Nov 25, 2022
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
|
We've decided to move this feature directly to https://github.com/open-rmf/rmf_obstacle_detectors. I'll squash merge this branch into a newly created |
|
Moved open-rmf/rmf_obstacle#21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
rmf_obstacle_ros2package. It depends on open-rmf/rmf_internal_msgs#42The package currently provides:
rmf_obstacle_ros2library that providesa.
Responderpure abstract classes that users may implement to take action on detection results.b.
ObstacleManagerto support users with building their own detection/responder piplelinesc. Utility functions to convert between sensor_msgs types and
Obstaclesmsg.lane_blockerexecutable that subscribes to/rmf_obstaclesand decides whether to close/open lanes or adjust speed limits of lanes that have obstacles in their vicinities. Various thresholds may be adjusted via ROS 2 params.TODO(YV): Move implementation of lane_blocker as a separate class that derives
Responder. Then also provide a node that subscribes to/rmf_obstaclesfor processing all obstacles.